Skip to content

refactor(git): retype get_commits parameter to make it more friendly to call sites#1506

Merged
Lee-W merged 1 commit intocommitizen-tools:refactorsfrom
bearomorphism:refactor-get-commits
Jun 8, 2025
Merged

refactor(git): retype get_commits parameter to make it more friendly to call sites#1506
Lee-W merged 1 commit intocommitizen-tools:refactorsfrom
bearomorphism:refactor-get-commits

Conversation

@bearomorphism
Copy link
Collaborator

@bearomorphism bearomorphism commented Jun 5, 2025

Wait for #1466

Description

Checklist

Code Changes

  • Add test cases to all the changes you introduce
  • Run poetry all locally to ensure this change passes linter check and tests
  • Manually test the changes:
    • Verify the feature/bug fix works as expected in real-world scenarios
    • Test edge cases and error conditions
    • Ensure backward compatibility is maintained
    • Document any manual testing steps performed
  • Update the documentation for the changes

Documentation Changes

  • Run poetry doc locally to ensure the documentation pages renders correctly
  • Check and fix any broken links (internal or external) in the documentation

When running poetry doc, any broken internal documentation links will be reported in the console output like this:

INFO    -  Doc file 'config.md' contains a link 'commands/bump.md#-post_bump_hooks', but the doc 'commands/bump.md' does not contain an anchor '#-post_bump_hooks'.

Expected Behavior

Steps to Test This Pull Request

Additional Context

@bearomorphism bearomorphism force-pushed the refactor-get-commits branch from 85683b8 to 484f1f3 Compare June 8, 2025 09:09
@bearomorphism bearomorphism changed the title Refactor get commits refactor(git): retype get_commits parameter to make it more friendly to call sites Jun 8, 2025
@codecov
Copy link

codecov bot commented Jun 8, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.87%. Comparing base (a9cd957) to head (3ecbe83).
Report is 3 commits behind head on refactors.

Additional details and impacted files 
@@            Coverage Diff             @@
##           refactors    #1506   +/-   ##
==========================================
  Coverage      97.87%   97.87%           
==========================================
  Files             57       57           
  Lines           2677     2677           
==========================================
  Hits            2620     2620           
  Misses            57       57
Flag Coverage Δ
unittests 97.87% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@bearomorphism bearomorphism force-pushed the refactor-get-commits branch from 484f1f3 to 3ecbe83 Compare June 8, 2025 13:55
@bearomorphism bearomorphism marked this pull request as ready for review June 8, 2025 13:56
@Lee-W Lee-W merged commit ca0f250 into commitizen-tools:refactors Jun 8, 2025
18 checks passed
@bearomorphism bearomorphism deleted the refactor-get-commits branch June 13, 2025 05:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Lee-W Lee-W Lee-W approved these changes

@woile woile Awaiting requested review from woile

@noirbizarre noirbizarre Awaiting requested review from noirbizarre

Assignees

No one assigned

Labels

pr-status: wait-for-review type: refactor

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@bearomorphism @Lee-W